Skip to content

feat: add Wald distribution variance package #9730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
manit2004 wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

feat: add Wald distribution variance package #9730

manit2004 wants to merge 8 commits into from

Conversation

@manit2004
Copy link
Contributor

@manit2004 manit2004 commented Jan 13, 2026

Progresses #209 .

Description

What is the purpose of this pull request?

  • This is a WIP pull request. Currently the core functionalities of Wald Distribution variance package has been implemented. Feedback needed on this implementation.

Tests, docs, examples and benchmark is yet to added, pending approval of the core implementation.

Related Issues

Does this pull request have any related issues?

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 13, 2026
@manit2004 manit2004 mentioned this pull request Jan 13, 2026
Open
@Planeshifter Planeshifter self-requested a review January 13, 2026 17:53
Planeshifter
Planeshifter reviewed Jan 13, 2026
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/wald/variance/src/main.c Outdated
stdlib_base_is_nan( mu ) ||
stdlib_base_is_nan( lambda ) ||
lambda <= 0.0 ||
mu <= 0.0
Copy link
Member

@Planeshifter Planeshifter Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is missing an indentation level - it should have two tabs to match the other conditions above it.

Suggested change
mu <= 0.0
mu <= 0.0

Planeshifter
Planeshifter requested changes Jan 13, 2026
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

First thing I noticed is that README.md is missing and should be added.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 13, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 18, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/normal/variance $\color{green}175/175$
$\color{green}+0.00%$ 		$\color{green}9/9$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}175/175$
$\color{green}+0.00%$
stats/base/dists/wald/variance $\color{green}176/176$
$\color{green}+0.00%$ 		$\color{green}10/10$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}176/176$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 18, 2026
@manit2004
Copy link
Contributor Author

manit2004 commented Jan 18, 2026

@Planeshifter variance package has been implemented fully. Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Awaiting requested review from Planeshifter

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manit2004 @stdlib-bot @Planeshifter